Skip to content

Set EnableDataShardInMemoryStateMigrationAcrossGenerations = true by default #20715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2025
Merged

Set EnableDataShardInMemoryStateMigrationAcrossGenerations = true by default #20715

merged 1 commit into from
Jul 8, 2025

Conversation

snaury
Copy link
Member

@snaury snaury commented Jul 7, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Since 25-1 supports in-memory migration between datashards we can enable migration across generations by default.

@snaury snaury self-assigned this Jul 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 7, 2025 •
edited
Loading

⚪ 2025-07-07 11:40:58 UTC Pre-commit check linux-x86_64-release-asan for 807dc76 has started.
⚪ 2025-07-07 11:41:52 UTC Artifacts will be uploaded here
⚪ 2025-07-07 11:46:39 UTC ya make is running...
🟡 2025-07-07 14:16:57 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16383 16025 0 128 202 28

🟢 2025-07-07 14:18:26 UTC Build successful.
🟢 2025-07-07 14:18:56 UTC ydbd size 3.9 GiB changed* by +464 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2674df3 merge: 807dc76 diff diff %
ydbd size 4 200 044 824 Bytes 4 200 045 288 Bytes +464 Bytes +0.000%
ydbd stripped size 1 455 242 360 Bytes 1 455 242 296 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 7, 2025

🟢 2025-07-07 11:41:30 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 7, 2025 •
edited
Loading

⚪ 2025-07-07 11:43:52 UTC Pre-commit check linux-x86_64-relwithdebinfo for 807dc76 has started.
⚪ 2025-07-07 11:44:03 UTC Artifacts will be uploaded here
⚪ 2025-07-07 11:47:41 UTC ya make is running...
🟡 2025-07-07 13:34:43 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38826 36092 0 2 2686 46

⚪ 2025-07-07 13:38:14 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-07-07 13:53:53 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
766 (only retried tests) 688 0 0 40 38

🟢 2025-07-07 13:54:03 UTC Build successful.
🟢 2025-07-07 13:54:22 UTC ydbd size 2.2 GiB changed* by +64 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2674df3 merge: 807dc76 diff diff %
ydbd size 2 387 893 536 Bytes 2 387 893 600 Bytes +64 Bytes +0.000%
ydbd stripped size 499 612 200 Bytes 499 612 264 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury marked this pull request as ready for review July 7, 2025 15:02
@snaury snaury merged commit 30a00c5 into ydb-platform:main Jul 8, 2025
14 checks passed
@snaury snaury deleted the enable-migrate-across-generations branch July 8, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azevaykin azevaykin azevaykin approved these changes

Assignees

@snaury snaury

Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snaury @azevaykin